Issue197

Title Some icons not displaying in the extension.
Priority bug Status done-cbb
Superseder Firefox Extension
View: 52
Nosy List jambo
Assigned To Topics Extension

Created on 2007-06-28.11:44:14 by jambo, last changed 2007-07-24.09:19:44 by timbl.

Messages
msg539 (view) Author: timbl Date: 2007-07-24.09:19:44
That icon has been removed, and the functionality provided in panes.  When other 
icons are added, the code about them currently has to be copied between 
tabulator.js for the online version and test.js for the extnsion version.  Any 
reason why it should't be in a common file?
msg484 (view) Author: jambo Date: 2007-06-28.11:44:14
Some icons (most notably the "Open in new window" icon) are not properly
displayed in the extension.  In the case of the "Open in new window" icon, it is
because of the following code:

                var linkButton = myDocument.createElement('input');
                linkButton.type='image';
                linkButton.src='icons/document.png';
                linkButton.alt='Open in new window';
                /*linkButton.onclick= function () {
                    return window.open(''+obj.uri,
				       ''+obj.uri,  'width=500,height=500,resizable=1,scrollbars=1')
                }*///TODO: Reimplement this.
                linkButton.title='View in a new window';
                rep.appendChild(linkButton);
        }

at outline.js#1490 , which indicates that the button doesn't even work
currently, anyway.  Icons need to be loaded into the Icon array the same way as
the other ones are in order to maintain consistency and guarantee functionality
in both the extension and the web app.

Other icons that this applies to include but may not be limited to the compass
rose / clock icons that indicate mappable / calendar-able data.
History
Date User Action Args
2007-07-24 09:19:44timblsetstatus: deferred -> done-cbb
messages: + msg539
2007-06-28 11:44:14jambocreate

To request an account, email [name of this project]@csail.mit.edu.